perf(Propagator): Always commit in batches#58406
Open
provokateurin wants to merge 1 commit intomasterfrom
Open
perf(Propagator): Always commit in batches#58406provokateurin wants to merge 1 commit intomasterfrom
provokateurin wants to merge 1 commit intomasterfrom
Conversation
provokateurin
requested review from
Altahrim and
ArtificialOwl
and removed request for
a team
CarlSchwan
approved these changes
Feb 18, 2026
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
perf/propagator/always-commit-in-batches
branch
from
d6b5320 to
15d2b5b
Compare
Member
Author
|
Tests are red, but I think they just need some manual calls to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure this is a good idea or not, but I've seen that parents are updated multiple times within the same request.
This should help, as they will only get updated once, but it might also result in more memory consumption if many changes need to be propagated within a single request.
We could also go half way and automatically commit if there are too many parents, like the scanner logic already does. This would at least limit the memory consumption and should still perform better.